strangelookingnerd

Results 143 comments of strangelookingnerd

@jenkinsci/badge-plugin-developers I would love to get this merged soon-ish especially since https://github.com/jenkinsci/jenkins/pull/9148 will make a visual change to the build history that I would love to use as a baseline...

> > I'm afraid that I won't be able to review it for several months. The Spring Security 6.x Upgrade project needs to have most of my attention for the...

> @strangelookingnerd did you seen my comments from the last review? Not sure what you are referring to. Can you link me the comments?

> > @strangelookingnerd I marked you in all of them If you are referring to https://github.com/jenkinsci/badge-plugin/pull/151#issuecomment-2121854951: I have recently updated the [PR description](https://github.com/jenkinsci/badge-plugin/pull/151#issue-2300934130) to reflect the current / final state...

> > > @strangelookingnerd I marked you in all of them > > > > > > If you are referring to [#151 (comment)](https://github.com/jenkinsci/badge-plugin/pull/151#issuecomment-2121854951): > > I have recently updated...

Merging the changes and creating `v1.x` branch in case we need it. I will start working on a changelog and cut a release hopefully end of next week.

> probably should also review/fix current warnings before merging this? Not sure if this has to happen _before_ merging it. Having the code scanning alerts target the `master` branch rather...

> This should be addressed via [a lint rule](https://github.com/bpmn-io/bpmnlint/tree/main/docs/rules#readme). There is no good reason to have multiple messages with the same name. On the other hand, does it hurt? >...

> Can you reproduce this locally on your machine? I indeed could see that test fail locally as well. Since I would not know how my changes could affect that...

> Now, the WildFly CI fails since it tries to use the Apache HTTP Client 4 modules. After consolidating the Apache HTTP Client version properties to one central property in...