strangelookingnerd

Results 143 comments of strangelookingnerd

Replaced by https://github.com/camunda/camunda-bpm-platform/pull/4408

@jenkinsci/job-dsl-plugin-developers any chance this can be reviewed, merged & released?

> This plugin seems to comply with https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ before this PR. This is true, however I'd argue that the [ExecuteDslScripts](https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-plugin/src/main/java/javaposse/jobdsl/plugin/ExecuteDslScripts.java) and [JenkinsDslScriptLoader](https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-plugin/src/main/java/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java) can be considered core functionallities of this plugin....

> Based on the `Jenkins.get().getPluginManager().getPlugin("config-file-provider") != null)` guard, they seem like they should load as described in https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/ -- are you saying that they aren't loading when the optional dependency...

> > * Remove `addHtmlBadge` as it does not provide any value over `addBadge` (given that any text is treated as HTML) > > That will break compatibility with existing...

Alright, I will try to work around any breaking changes and see what I end up with. I think starting a new plugin is not really what I was aiming...

I just pushed the latest changes that are slowly going towards a final state. I did my very best to keep backwards compatibility for existing pipeline scripts as well as...

The conflicts have been resolved.

The PR is ready for review. I updated the [description](https://github.com/jenkinsci/badge-plugin/pull/151#issue-2300934130) to reflect a high level view of the changes that are contained. The only thing that is currently missing is...

> It would be good to validate the changes against [jenkinsci/jenkins#9148](https://github.com/jenkinsci/jenkins/pull/9148) which does a complete rewrite of the history widget @mawinter69 That's a great idea! Thanks for bringing it up....