Steven Lambert

Results 454 comments of Steven Lambert

@namansancheti looks like we're going to be taking this on internally so you won't have to work on the changes.

Thanks for the changes. I'm unable to look at this this week but will try to look at it next week.

Thanks for the changes. Unfortunately something in those changes broke a bunch of the tests. Double unfortunately since you forced pushed I'm unable to see the newest changes compared to...

Develop is passing on my end. The way our tests are set up you have to build first before you test, otherwise the changes won't be tested.

This all looks good, thanks for the updates. I'm trying to finalize feedback from other teams about changing the `html` property, but once I get the all clear I should...

Thanks for the pr. These are just examples, but that same naming schema is used for other examples as well: * jasmine * jsdom * mocha I'm not opposed to...

Closing due to inactivity

After testing, I think the above code should fail the `aria-required-children` rule. Here are the results of my testing: * VO/Safari - Doesn't announce the grid, but using the up...

Thanks for the issue. After looking into I believe this is related to https://github.com/dequelabs/axe-core/issues/4752 where Chrome and Firefox are adding the carousel container to the tab order automatically. Because axe-core...

@marcobeltempo I don't believe anyone is working on this so a pr would be most appreciated