Samuel Stow comments

Results 49 comments of


                                            Samuel Stow

Fix deprecated methods for Android R

Hi @Sourav-21 thanks for the updated fix. Can you please address the build breakages? It seems as though all gradle wrappers may need to be updated to 6.5?

Fix deprecated methods for Android R

@Sourav-21 see #304 - once merged please sync this.

fixed Applovin Dependency file where no repository was set.

@rchallenger - sorry for the delay. Happy to bring this in if you can fix the indents and remove tabs.

Update AppLovinPostProcessBuild.cs

Hi, if you're still interested in submitting this, let's change to match [this code](https://github.com/googleads/googleads-mobile-unity/blob/master/source/plugin/Assets/GoogleMobileAds/Editor/PListProcessor.cs#L1) where we just check if UNITY_IOS is defined. It's more direct and meaningful.

reduce new thread count

@zmer007 thanks for the PR, sorry for delay. Can you please switch to a [single thread executor](https://developer.android.com/reference/java/util/concurrent/Executors#newSingleThreadExecutor(java.util.concurrent.ThreadFactory)) and change the method name from `submitToThreadPool` to `submitToExecutor`? Also resolve conflicts.

Fix interstitial performance on some Android devices

I have a change to banner positioning pending which I hope to release this week which may resolve this issue, so waiting on that before addressing this.

Ads Not Showing After Build ( Fix ) Added Preserve Attributes

@PayandaOnline can you sign the CLA?

Ads Not Showing After Build ( Fix ) Added Preserve Attributes

Thanks for the update @PayandaOnline - I'm still not 100% clear on what your comments mean. Do you have any links of resources I can review to understand the comments...

"Unable to convert data to string around character" error while requesting consent info

Hi, Can you capture the response and perhaps provide a sample project? We are unable to reproduce this error locally. Thanks Sam

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again

Thanks, this is a known issue and should be fixed in an upcoming release scheduled for mid september. On Tue, Aug 20, 2019 at 6:55 PM shewenbiao wrote: > ads...