Istvan Toth
Istvan Toth
We should go further. We should remove hbase_config_path, and use hbase_conf_dir from phoenix_utils.py instead in every script. The same goes for hbase_conf_path, which is no longer needed.
Can you do the same for the rest of the scripts ? psql, pherf, etc.
Once we are at it, can we also replace all phoenix-client JARs with phoenix-client-embedded + log4j backend jar ?
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: |...
I am generally not convinced that overriding poolsize from the client side is a good idea. It is very easy to overload the cluster by specifying a too large poolsize....
Also see my objection from the ticket that this will cause discrepancy between the poolsize used by the client, and by the Index rebuilding initiated by MetaDataObserver.
I agree @wangchao316 that tuning poolsize is crucial for performance optimization. It is just my opinion that the tuning should be done on the cluster size, in hbase-site.xml, rather than...
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 5m 22s | Docker mode activated. | ||| _ Prechecks _...
Yes, I have, at the time. But there were changes in Omid since then, and we're gonna have to test again, once the Omid HBase2 API migration has landed in...
The failing tests are known flakeys.