phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-6485 clean up sqlline.py classpath

Open richardantal opened this issue 3 years ago • 4 comments

Change-Id: Iba524a971eb62c42a36eaff4ae303aab5f04e298

richardantal avatar May 31 '21 12:05 richardantal

We should go further.

We should remove hbase_config_path, and use hbase_conf_dir from phoenix_utils.py instead in every script. The same goes for hbase_conf_path, which is no longer needed.

stoty avatar May 31 '21 13:05 stoty

Can you do the same for the rest of the scripts ? psql, pherf, etc.

stoty avatar Jun 01 '21 06:06 stoty

Once we are at it, can we also replace all phoenix-client JARs with phoenix-client-embedded + log4j backend jar ?

stoty avatar Jun 01 '21 11:06 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: patch 0m 3s https://github.com/apache/phoenix/pull/1243 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/phoenix/pull/1243
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1243/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jul 26 '21 07:07 stoty

This has been merged a long time ago.

stoty avatar Dec 16 '22 10:12 stoty