hannah

Results 180 comments of hannah

Reading through this again, this section https://matplotlib.org/devdocs/devel/color_changes.html#default-heat-map-colormap has a nice list of criteria for adding a new colormap that we may be want to bundle/rework into the coding guidelines or...

> So we can't really preview it (at least with this workflow). Have I managed a catch 22 where we can't see how it fully works before discussing b/c that...

> However, I don't think it would look too different from how it does now with the "Merging is blocked" error due to not having any approving reviews. Yeah, in...

I think the other option for making this always run is maybe making it a required workflow https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/required-workflows

@ksunden has a pass and a fail state now

> It's not really waiting for another PR, right? That was just for testing? Yup!

Though now it doesn't seem to be working 🤦‍♀️

![Screenshot_20240311-212617.png](https://github.com/matplotlib/matplotlib/assets/1300499/a651a0f9-eb84-4dca-9d80-752e4dc50338) This is what I see? Maybe it's cause I'm on the app?

ok, so looks like it's working but there's just some lag sometimes

> With this change we have to further remember a list of tags that will opaquely block merging and remember which ones we need to remove to un-block It's the...