Shaun Tonstad

Results 17 comments of Shaun Tonstad

I now see that this is aligned with the 1.10 milestone. If ready, is there a way to test a pre-release in Unity3D to confirm resolution?

Thanks you! It looks like that resolves some of the AOT issues but this one remains (Drawing.DrawImageProcessor+ProcessorFactoryWorker~1: ``` System.ExecutionEngineException: Attempting to call method 'SixLabors.ImageSharp.Processing.Processors.Drawing.DrawImageProcessor+ProcessorFactoryVisitor`1::Visit' for which no ahead of time...

I'm not familar with the conventions the ImageSharp team uses. The following addition (hack) to AotCompilerTools.cs resolves the issue for me: ``` [Preserve] private static void AotCompileDrawImageProcessor() where TPixel :...

The existing logic in AotCompilerTools appears to define types without instantiation which is elegant compared to my instantiation hack job. I'm similarly ignorant of how AOT compilation resolves types.

``` using (Image sourceImage = Image.Load(screenshotBytes)) // load up source images using (Image outputImage = new Image(targetWidth, targetHeight)) // create output image of the correct dimensions { GraphicsOptions graphicsOptions =...

Yes, I'm calling via Seed w/ AotCompileDrawImageProcessor() and this works.

> The workaround with a "seeding" method are not great because e.g. they prevent trimming unused code - suddenly a lot of code is needed just because it's referenced from...

The corresponding Unity issue (opened 7/16/21) is "1351111 (Open) IL2CPP AOT Compilation Regression". They have been given a reproduction project which uses ImageSharp 1.0.3. Pragmatically speaking, Unity isn't likely to...

If the ImageSharp team asserts the behavior is a Unity bug but the Unity team refers to it as documented behavior, it may be wise to specify that ImageSharp support...

> @stonstad do you have access to this issue? Can you post a reference to [#1703 (comment)] Already done! After reading @MichalStrehovsky's helpful comment I updated the Unity ticket with...