Stijn de Gooijer comments

Results 621 comments of


                                            Stijn de Gooijer

Redesign `cut` and `qcut`

Let's go with `breaks`. @orlp could you set up a PR for this?

Add expression to mirror `math.isclose` and `numpy.isclose`

I think this is a good option to have. I don't like `is_close` as a name though 🤔

Add expression to mirror `math.isclose` and `numpy.isclose`

I personally like `almost_equal`. We can bikeshed the exact name if someone opens a PR for this.

Allow `step`/`interval` parameter in `ranges` functions to take an expression

Yes, I definitely want this to work. I want to expressify `step` / `interval` for the range functions when I get to it.

feat(rust, python): add dt.quarter_start, dt.quarter_end, dt.year_start and dt.year_end

I've felt a bit apprehensive pressing the merge button, because I'm not sure these methods are really that useful. Don't we already offer the right tools to do this yourself?...

chore(python): Fix mypy errors on Windows

Thanks - I'll double check this on my Windows PC. Perhaps it can be structured a bit differently not to need these ignores in the first place.

feat(python): Add support for `async` SQLAlchemy connections to `read_database`

Sounds good!

feat(python): Add support for `async` SQLAlchemy connections to `read_database`

@alexander-beedie I just got a spurious failure in the CI, I think it might be related to the async test added in this PR as it looks async-ish. What do...

feat(python): add "match_any" param/option to the `by_name` selector

This is similar to the discussion in https://github.com/pola-rs/polars/issues/11913 I'm not sure there needs to be a parameter for this, but if there is one, I wouldn't want to call it...

feat(python): add "match_any" param/option to the `by_name` selector

I really don't want to merge this with the current parameter name. It's extremely unclear to me. What are you matching? Any of what? What would it mean to set...