chore(python): Fix mypy errors on Windows
We need to consider two scenarios:
- An attribute is undefined, mypy is unhappy, we add:
# type: ignore[attr-defined]. - An attribute is defined, mypy is unhappy about the 'ignore' comment, we add:
# type: ignore[unused-ignore].
So we need both comments in one place: # type: ignore[attr-defined,unused-ignore].
The documentation refers to the Angular convention, which mentions the build type.
In the log I see chore as well, which is more frequent.
git log --oneline | rg "build\(python\)" | less # many lines
git log --oneline | rg "chore\(python\)" | less # few lines
You may want to fix the name of this PR.
Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 81.47%. Comparing base (
4048c3a) to head (1cc86f2). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| py-polars/polars/_cpu_check.py | 0.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #16570 +/- ##
==========================================
- Coverage 81.49% 81.47% -0.02%
==========================================
Files 1414 1414
Lines 185525 185525
Branches 2997 2997
==========================================
- Hits 151191 151165 -26
- Misses 33818 33844 +26
Partials 516 516
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks - I'll double check this on my Windows PC. Perhaps it can be structured a bit differently not to need these ignores in the first place.