lsy

Results 39 comments of lsy

Hi @tao12345666333 , I can help to implement `TCPRoute`. Can you assign it to me?

> @stillfox-lee sorry, The `TCPRoute` task has been publised through the OSPP project. [1] And @AlinsRan has already claimed the task. He will finish the job in two months. >...

Hi @tao12345666333 , I'm trying to use `traffic-split` plugin to implement `UDPRoute` traffic control with `weight` logic like `HTTPRoute`. Then I go through the [doc](https://apisix.apache.org/zh/docs/apisix/plugins/traffic-split/), those use cases are all...

> @stillfox-lee But we may be able to have some discussions, if it is convenient for you, you can contact me at `[email protected]` and we can schedule a meeting to...

Hi, I got a little confused about this issue. Didn't we already support this feature by ApisixRoute HTTP plugin?

> @stillfox-lee We can indeed do this already by using a plugin in the ApisixRoute resource. > > The purpose of this issue is to add annotations to the Ingress...

> You can add `focus` to only run a specific test case Yes, `focus` can do that. But ginkgo will teardown after every test case. I wanted to keep env...

> Just add a sleep? 😜 抱歉,我的英文水平不能准确地表达我的意思,所以我用中文回复了。 当然,通过`sleep`是可以保留现场,留足够多的时间来 debug。但是,我觉得这不是一个优雅的方式。主要有以下几个原因: 1. 我们所讨论的是e2e-test的一些特殊性的随机错误,二次执行的时候它可能就不会发生了,所以,当测试用例执行失败之后再添加`sleep`,不能有效的定位这个场景下的问题。 2. 我在想对于**随机错误**这种问题,我们是否需要一种通用的解决方案?一种可以加入到e2e-test代码里的方案。比如说,在测试用例执行失败的时候,向k8s集群进行采样,获取足够多的信息来辅助我们定位问题。这样就不需要我们测试失败之后,加入`sleep`再次重跑,然后再看集群里面的实际情况来确定问题。 然后,关于随机错误。我猜想主要有两种原因:一是客观的集群环境问题导致,对于这种情况也许只能再次执行测试。二是我们的测试用例构造不完善,有一些边界情况会导致错误发生。对于第二种情况,我认为还是需要去解决的。 从我个人仅有的 PR 经历来看,CI 中经常会出现这种随机错误。从 contributor 或者是 reviewer来看,这其实是会耗费我们大量的时间成本的。所以我认为我们还是需要花费一些时间来提高测试的稳定性。 我不清楚这个方面业界的最佳实践是什么,如果可以给我一些指导的话,我可以在这方面为项目做一些改善。

> For example, we can add an environment variable. If it is run locally by the developer, when a failure occurs, the relevant resources will be kept and not deleted....

> If we had the concept of phase, we could split the data preparation into a shared data preparation function and a specific CRD preparation function. From my point of...