stiegerc comments

Repositories
Issues
Comments

Results 3 comments of


                                            stiegerc

feat: [MR-592] Define and enforce callback limits

> We no not want reaching this cap to result in canisters being unable to make any calls at all, ... Typo in the 3rd paragraph of the description.

feat: Introduce msg_limit for application subnets in payload builder

AFAICT `msg_limit` in [take_prefix()](https://sourcegraph.com/github.com/dfinity/ic/-/blob/rs/xnet/payload_builder/src/certified_slice_pool.rs?L764) is now always `Some(_)` so the `Option` can be removed, but I left it in since I am not sure whether we may want to keep...

feat: Introduce msg_limit for application subnets in payload builder

> LGTM overall, I left a comment about the index juggling that I think can be simplified. What's unclear to me is whether we issue a warning if the stream...