Samuel Thibault comments

Results 293 comments of


                                            Samuel Thibault

rule fix#1

Please also update the expected output in the test files, see the check failures

configure does not check for g++, but it is used later on

It seems to be the unfortunate behavior of `AC_PROG_CXX`. I see a lot of `configure.ac` files that just use it and indeed not actually properly test in that case.

The change to tests/translate.test to detect #824 causes unexplained failures on some builds

For information, I have submitted as https://github.com/espeak-ng/espeak-ng/pull/1095 what I believe is proper boundary check. Of course dynamic reallocation would allow to avoid cutting speech, but at least: * the patch...

Update Kyrgyz

Please explain why this is needed, what it fixes. Also, see the check failure, possibly you have to update the test expected output.

Update Belarusian

Please see the checks failures

Update Arabic

Also, please see the build failure: ``` Using phonemetable: 'ar' Compiling: 'ar_listx' 30089 entries Compiling: 'ar_list' 136: Bad phoneme [I] (U+49) in: _0 s[-'IfR 251 entries Compiling: 'ar_emoji' 1639 entries...

Update Arabic

Please see the `make check` errors

Use continuous integration (CI) on all supported platforms

https://github.com/espeak-ng/espeak-ng/pull/1091 can be included for a start

Use continuous integration (CI) on all supported platforms

#1105 adds an usan profile, it depends on pull requests #1093 #1094 #1095 #1102 #1103 #1104 before we can merge it

Use continuous integration (CI) on all supported platforms

#1110 adds an asan profile, it depends on pull requests #1095 #1103 #1106 #1107 #1109 before we can merge it