Steffen Weinstock

Results 17 comments of Steffen Weinstock

Hi @danjoa , any objections against switching on DB constraints in bookshop?

todo: java code that sets `acceptEnabled`, `rejectEnabled`, `deductDiscountEnabled` needs to be removed

Yes, that is how I understand it. So we could remove the respective code to get the tests of this PR green, then merge it, and then check whether the...

... to make the tests green, all custom code referring to the virtual elements `acceptEnabled`, `rejectEnabled`, `deductDiscountEnabled` has to be removed, as these virtual elements are removed (replaced by calculated...

Simply removing the java code that accesses the removed virtual fields dosn't help: ``` Caused by: org.h2.jdbc.JdbcSQLFeatureNotSupportedException: Dieses Feature wird nicht unterstⁿtzt: "VIEW" Feature not supported: "VIEW"; SQL statement: UPDATE...

Hi @rjayasinghe @drktfl @chgeo @rbrechter , this change solves the problem we had w.r.t. the dataSource URI in the manifest.json: either it worked for deployed apps, or it worked for...

Just tried without @Core.Comuted and without @Core.ComputedDefaultValue -> works Removing @UI.Hidden -> popup asks for input

So what should we do? * have only `@UI.Hidden` (remove `@Core.Computedby` and don't add `@Core.ComputedDefaultValue`) * add `@Core.ComputedDefaultValue` for future use * leave everything as it is ?

> still under discussion on Fiori Elements' side. not really a surprise :-)

see https://sapjira.wdf.sap.corp/browse/FIORITECHP1-22529 once this is done, set `@Core.ComputedDefaultValue` and remove `@UI.Hidden`