Stefan Kieleithner

Results 10 comments of Stefan Kieleithner

Just wanted to check in on the status here. I'd love to get this PR merged, so let me know if there is anything left for me to take care...

> Is there a reason for not using scroll API which is much more precise than swipe? @khandpur I'm not quite sure if I understand your question correctly, so please...

@khandpur Sorry for the long delay, but I've now added unit and functional tests for the precise swipe actions. Looking forward to your feedback!

@khandpur Just wanted to ping to check on the status of this PR. I would really appreciated if you could have another look at this PR and consider merging it....

Thanks for the review @khandpur. I addressed all your feedback, and fixed the code style nits, adjusted the wrong indentations, added nullability macros to `GREYPreciseSwipeAction.h`, and also rebased this branch...

Thank you for reviewing this PR and getting it merged! I really appreciate it. @tirodkar I also addressed your review feedback now and fixed the typo.

Thank you for the quick reply John! > The behaviour is the same in Xcode (counterparts -> Swift 5 interface) so I think this is likely a Swift bug/limitation. Yes,...

My apologies for the delay here. I just created an issue on bugs.swift.org via https://bugs.swift.org/browse/SR-16109.

I also reported this as [FB16117850](https://github.com/PSPDFKit-labs/radar.apple.com/tree/master/FB16117850%20-%20View%20lifecycle%20event%20methods%20not%20being%20called%20when%20using%20a%20UIViewControllerRepresentable%20in%20a%20TabView%20with%20tabViewStyle(.page)) in December and just got a reply on the feedback to retest this with iOS 18.4 beta 1. And it turns out that this...