Steve Szczecina

It'd be great to allow the before, onOrBefore, after, onOrAfter options accept a function that returns a date. This way every time the validator is executed we can re-evaluate those...

@snewcomer just put up a PR adding the function support for date validator options. #281

The current implementation of `isVisible` is based on jquery's [`:visible` pseudo-selector](https://github.com/jquery/jquery/blob/4a2bcc27f9c3ee24b3effac0fbe1285d1ee23cc5/src/css/hiddenVisibleSelectors.js#L11-L13) which states the following: ``` Elements are considered visible if they consume space in the document. Visible elements have...

Related to #418 I did a little digging and found out why this is the case. TLDR isVisible and isNotVisible are based on jquery's :visible pseudo selector. https://github.com/simplabs/qunit-dom/issues/418#issuecomment-523142483

Maybe related: https://github.com/html-next/ember-raf-scheduler/issues/5

Related: https://github.com/html-next/vertical-collection/issues/197

I spent some time debugging this with some teammates. We were able to identify the root cause of this issue, which is a faulty piece of conditional logic inside the...

FWIW we've also seen this error show up in our error logger.

@JonAtOlo You can pass an `occlusionTagName="li"` arg to the vertical-collection component to fix this https://github.com/html-next/vertical-collection/blob/master/addon/components/vertical-collection/component.js#L150

I'd be interesting in contributing type definitions for ESA if there is interest from the maintainers. @marcoow @BobrImperator Any opinions on how best to add type definitions? An index.d.ts file...