Steve Oliver

I'm working on this..

Current status: ❯ grunt test Running "shell:test" (shell) task Exception loading helper: .../the-abstractions-are-leaking/spec/ng-active-resource/spec-helper.js [TypeError: object is not a function]

@bojanz, Check out the latest fails ... [why should ->refresh() change qty from 2 to 1](https://github.com/drupalcommerce/commerce/blob/1503d2f544848d5fc63089d697171012fff0da59/modules/order/tests/src/Kernel/OrderRefreshTest.php#L225)?

Thanks @olafkarsten. Working on getting tests passing now, and after discussion with @BBGuy about his min/max comment, I agree that makes sense, and will make that change as well.

Rebased and PHP_INT_MIN and PHP_INT_MAX for min and max.

This looks good, @GoZOo - think you could create a test for this in https://github.com/drupalcommerce/commerce/blob/8.x-2.x/modules/log/tests/src/Kernel/CartIntegrationTest.php ? Then I'd say this is good to go.

Needs work. See last fail.

This needs a re-roll, then we can do an updated review.

It looks like there are still outstanding changes requested by @crenshaw-dev

This would be very helpful - in line with how load balancers can be named via `service.annotations.kubernetes\\.digitalocean\\.com/load-balancer-name`. Anything I can do to help move it forward?