Steven Sacks

Results 24 comments of Steven Sacks

@fedeci This is different than the change you proposed because it is just adding aliases, not renaming everything. Whatever your political views, at the end of the day, we are...

I think there’s an important difference. You weren’t just adding aliases, you were suggesting deprecating the words blacklist and whitelist, renaming files, etc. I am saying do not change anything....

I suppose I could always apply the chromatic decorator and inside of it do the check for `isChromatic()` ```ts import React from 'react'; import isChromatic from 'chromatic/isChromatic'; const Chromatic =...

Please let me know when I can pull and test this PR in my app and I'll let you know how it works! 👍

@satya164 I've been trying to test this pull request but I'm getting an error: ```bash npm i -S "git://github.com/styled-components/babel-plugin-styled-components.git#fd610c1e083f92678e8133fe807192d0d7cfba7c" ``` ```json "babel-plugin-styled-components": "git://github.com/styled-components/babel-plugin-styled-components.git#fd610c1e083f92678e8133fe807192d0d7cfba7c" ``` ```bash ./src/components/App/index.js Error: Cannot find module...

@satya164 can you please let me know how to npm install this pull request? Thanks!

@satya164 I tried that and I got the following error. ```bash Error: Cannot find module 'styled-components/macro' from '/Users/steven/Development/project/src/components/App' ``` ![error](https://user-images.githubusercontent.com/162252/50744274-11bb5f80-1265-11e9-9104-7bd6ac0d3b6f.png) Both of the libs are showing up as not installed.

@mxstbr Would you be willing to merge this into a release candidate to make things easier?

Thanks! I’ll give it a shot.