Steven Hartland

Results 293 comments of Steven Hartland

I can't see the benefit of this I'm afraid. Are you able to explain why this is needed?

Sorry I don't follow what do you mean by load in balance?

Thanks for the details. Seems like the unbalanced nature is actually an issues with the LB which is choosing which proxy the client is connecting to. FIFO nature of is...

If I understand the description of the problem correctly it sounds like the issue is with the proxy, so that's where the fix should be done. This is because, as...

> Just add an option and let the user decide. The problem with that is it will break connection clean up, causing a different problem.

> I may not explain clearly, please refer to for details [go-redis/redis#1819](https://github.com/go-redis/redis/issues/1819) . I understand the problem, in short LIFO results in unbalanced use of connections in the pool, but...

> there is a special condition that the connect rise suddenly and one proxy very slowly, FIFO will always get the slowly connect and the state will continued I'm not...

Indeed this would require a new method.

Yes you can see the comments on the https://github.com/gomodule/redigo/pull/442

There is already a https://github.com/gomodule/redigo/pull/571 for this. The same issue applies to this is that this breaks connection cleanup and is only needed to solve a problem outside of this...