Steven Hartland

Results 293 comments of Steven Hartland

Checking to see if you could address the feedback @alphagot812

> Is this working for `XREAD` or `XREADGROUP`? I wonder this is not working well for them because the nested structure is different, sorry if this is out of scope....

That makes sense to me @tk42 does that answer address your concerns?

This is a issue not a PR, are your referring to #557 ?

Can someone write a test that demonstrates this behaviour please.

I believe this is pooled connections only as its part of `activeConn` https://github.com/gomodule/redigo/blob/master/redis/pool.go#L477

Looks like the proposal https://github.com/golang/go/issues/53003 has been accepted recently so we can look to use those when they are implemented.

Hi @wuzuoliang could you describe what issue this is trying to fix?

Just following up on this @wuzuoliang ?

> something like this [go-redis/redis#1820](https://github.com/go-redis/redis/pull/1820) That's an example of a similar function, but what is the benefit of that?