Steven Benisek

Results 10 comments of Steven Benisek

You could remove the `createConnected*` factories and let the user handle the "connected" concept via [Context](https://reactjs.org/docs/context.html). It's a well documented pattern and removes complexity from `react-values`. What do you think...

Both [cxs](https://github.com/jxnblk/cxs) and [Free-Style](https://github.com/blakeembrey/free-style) support feature queries. The syntax is equal to that of media queries. In the case of Styletron it would look like this: ```js import {injectStyle} from...

When reviewing especially keep an eye on: - Typescript definitions (I'm by no means an expert, would love to get feedback) - Error handling if the browser doesn't support `window.FontFace`...

No, it's absolutely a valid comment. In fact, I thought about `url` and `format` as props myself. The reason I didn't do it is because with `source` you can add...

You do get limited runtime feedback. If you call `window.FontFace` with an invalid source it will throw a `DOMException`. You're not completely left in the blind. Might just stick with...

I'll see if I can make this work. Thanks for the suggestion 😄

Untill then, this should work: ```js import autoExternal from 'rollup-plugin-auto-external'; import shim from 'rollup-plugin-shim'; import builtins from 'builtins'; export default { input: 'index.js', external: builtins().filter(id => id !== 'readline'), plugins:...

I'm thinking about moving the `external` option to the root of the options object. I don't think this has to be limited to builtins. What do you think @DrSensor? ```js...

> For more granular control: Care to elaborate about this @DrSensor? Do you have a specific use case in mind?

[rollup-plugin-babel-runtime-external](https://github.com/stevenbenisek/rollup-plugin-babel-runtime-external) should do the trick for you. Care to give it a go and tell me how it went?