Steven Lin comments

Repositories
Issues
Comments

Results 3 comments of


                                            Steven Lin

Fix Potential Race on Logger

> I think its better if we move `if defaultLogger == nil ` inside `once.Do` > What do you think ? Not sure what is the concern to not assign...

Fix Potential Race on Logger

> My concern is that init() is always called, so if we import a package that has an init function, it will be executed. > Since Logger is used by...

Fix Potential Race on Logger

> Also the proper use of Logger was intended in the way where you call GetLogger() and then use that object everywhere in that scope Fixed as comment.