Steven Kraft

icon indicating a website link https://steven-kraft.com/

icon location Philadelphia, PA icon location My focus is on Japanese Learning Tools, but I often like to experiment. I also try to contribute where I can.

Results 4 issues of Steven Kraft

Prevent rendering pages without annotations

1 comment

Since rendering a page is a somewhat costly operation, pages shouldn't be rendered unless getAnnotations() returns more than 0 annotations. Otherwise, there is no reason to render. This will greatly...

Unnecessary page rendering when extracting highlights

Hi, I noticed that `await page.render(renderContext, annotations);` gets called even if `annotations.length` is 0. Is there a reason for this? I think making it so that only pages with annotations...

Added spellcheck functionality using electron-spellchecker library

Added spell-checking functionality using [electron-spellchecker](https://github.com/electron-userland/electron-spellchecker) `sudo apt-get install libx11-dev libxkbfile-dev` is now needed for linux builds I think. I modified `.travis.yml` to deal with this change. Not sure if there...

Wine Prefix set to SumatraPDF directory?

`WineAppRun.sh` seems to be hard-coded to set the wine prefix directory to `~/.config/SumatraPDF` Seems a bit odd and may be related to issues with minimization, but I'm not sure.