Steven Johnson comments

Results 261 comments of


Steven Johnson

Some apps are missing CMake builds

> I fear it has rotted. I will bet you $1 that all the iOS and Android-specific builds are totally rotten. Is there a way to target these via CMake?

Incorrect results with nan and halide.maximum on a reduction domain

Are you compiling with `strict_float`? If not, Halide defaults to the equivalent of `-ffast-math`, which allows LLVM to assume that NaN and Inf never exist.

Benchmarking local_laplacian segfaults

Is this still active? Does it need investigation?

Use thread-local context and stream in CUDA runtime.

Is this PR still active? Should it be closed?

Use thread-local context and stream in CUDA runtime.

I now sorta think that having some Target strings quietly instantiate GPU contexts to do sniffing is a bug and not a feature -- IMHO it's not at all obvious...

RFC: Output universal binary when CMAKE_OSX_ARCHITECTURES is defined.

> I need access to an M1 Mac to test this. @steven-johnson - can I use the buildbot for a while? OK with me, but @abadams is the one to...

RFC: Output universal binary when CMAKE_OSX_ARCHITECTURES is defined.

Any updates on this PR?

RFC: Output universal binary when CMAKE_OSX_ARCHITECTURES is defined.

Is this PR still active? Should it be closed?

Use Ninja for packaging on Windows

Presumably we can fix this once https://github.com/halide/Halide/issues/6910 lands (the relevant comment at master.cfg:912 indicates the bug is in CMake 3.18)?

Extend fork_async_producers to support functions scheduled with compute_with

Is this just awaiting review?