Steven Johnson
Steven Johnson
Assigning to @pranavb-ca for triage.
Google builds exclusively using close-to-trunk LLVM in this case, so we saw it with trunk as of mid-September 2022 -- if it's no longer happening in trunk, it must be...
> since it mkdoc doesn't seem to do a great job with groups Do you say this based on testing, or based on documentation?
Debugging further, the `metal` case is crashing inside LLVM: ``` frame #3: 0x000000010f7e6b86 libHalide.dylib`llvm::slpvectorizer::BoUpSLP::getEntryCost(llvm::slpvectorizer::BoUpSLP::TreeEntry const*, llvm::ArrayRef) + 20118 frame #4: 0x000000010f7ebff5 libHalide.dylib`llvm::slpvectorizer::BoUpSLP::getTreeCost(llvm::ArrayRef) + 1013 frame #5: 0x000000010f806b1e libHalide.dylib`llvm::SLPVectorizerPass::tryToVectorizeList(llvm::ArrayRef, llvm::slpvectorizer::BoUpSLP&, bool)...
Issues doesn't occur in LLVM15. Going to try to bisect in LLVM16 to see if it's an injection from upstream. (Could have been there for a while, as our buildbots...
`The vector and scalar versions of op_phaddw_285 disagree. Maximum error: 60123`
buildbots are green -- is this ready to land?
Monday Morning Review Ping -- where does this PR stand? Is it still likely to be dropped in favor of #6884?
Yikes. Sorry about that. Clearly we are overdue to add proper testing for negative (and zero) strides, and to explicitly document that they are legal. (Or, alternately, to forbid them,...