steven
steven
hi, I didn't notice you create one too. I just re-commit the PR #30612, including more deletion of TerminalTotalDifficultyPassed. you can choose rebase that one or not.
your commit contains my updates, closing mine.
I write [a simple benchmark test](https://github.com/stevemilk/erigon/blob/test/tests/test.go), here's the benchmark result: ``` CPU Cores: 10 Tasks number: 1000 === CPU-Bound Task Benchmark === 1 goroutines: 335.22075ms 10 goroutines: 39.401667ms 100 goroutines:...
Hi Sir, I want help fix this issue but have a question: In `stage_exec` , external rwtx is defined as from kv.chainDB. It can be nil if noCommit==false, and that's...
draft a pr #12097 to enable stage_bor_heimdall to commit partial progress, is this as expected?
> FYI: seems i trying something similar: #12380 @AskAlexSharov Got it. one thing special in this PR is i try to keep `closeAndRemoveFiles` thread safe without lock, not sure if...
what I'm thinking here is exactly point1, canDelete==true seems not enough. assuming two consecutive readers read segX during merge: 1. merge step1: integrateMergedDirtyFiles marks segX as canDelete = true 2....
thanks, you're correct about merge, i will work on point3 later
``` delSeg.canDelete.Store(true) if delSeg.refcount.Load() == 0 { delSeg.closeAndRemoveFiles() } ``` we have above code to determine closing files or not. But in fact `refcount` cannot guard files If the code...
i mean here, during the Prune: https://github.com/erigontech/erigon/blob/baf0a609131bd09f9a5f138be025c5ccd2ca1485/turbo/snapshotsync/snapshots.go#L1281