Steven Luscher comments

Results 158 comments of


                                            Steven Luscher

trafficstars

[WIP] Create subpackages for internal-ish code

> Is there no way we can do this as a build step instead? Do what; add the extensions? No, because once you change to `"moduleResolution": "NodeNext"` it's gg.

[WIP] Create subpackages for internal-ish code

> What exactly is NodeNext changing in our compiled code that makes subpackages possible? I think subpackage imports just straight up don't work unless `moduleResolution` is `node16` or higher. With...

[WIP] Create subpackages for internal-ish code

Meh.

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

Without even getting into that, would you agree that the objective of this existing code was to set `code` to a default value if it was not set by the...

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

Here's a positive outcome that could result from landing this PR: Someone who writes this test, whose intent is to assert that the server closed uncleanly, will not have to...

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

That should do it.

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

Also, I opted for a more compatible syntax, rather than the nullish coalescing operator, lest someone be running tests in an environment that doesn't support it.

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

Thanks for your time.