Results 286 comments of Steve Cotton

I'd assume this issue is "publish mainline's achievements to Steam", along with a tool that might do that. I wouldn't want to open an argument among the Wesnoth dev team...

@Dalas121 is there anything else to do here? Reminder to squash-merge the PR.

The test I wrote in #9074 should use `[filter_adjacent]` - `[filter_adjacent_location]` should be a terrain filter. There's other problems with it, but those tests aren't ready for testing, sorry. That's...

Have the ability check whether the terrain is `Ke` or `Gg`?

In which maps? As this is tagged with "good first issue", I worry that we'll encourage someone to spend ages improving 2p_Aethermaw, only to decide afterwards that it looks better...

In 1.16 this also affects unit-level special notes. Tested with 1.16.2+dev (d96968b2ec0ea3198982fc530ee68054dd19af63), adding the markup into `INTERNAL:SPECIAL_NOTES_NIGHTSTALK`.

> `text` renders correctly, but `text='text'` does not. Only in the sidebar's rendering. If you try to open the help browser, `text` (and probably `text`) will trigger #4507.

I'd prefer to merge as-is, in the hope that the optimisation could be backported to 1.18, and then leave further changes to someone else.

It ought to be a bit faster on the load-game screen too. Probably not a measurable amount, but the filename check gets called a lot when parsing TerrainGraphicsWML, because `terrain_build::add_rotated_rules`...