Steve Cotton
Steve Cotton
There are active forks, for example the AVH fork, https://github.com/petervanderdoes/gitflow-avh However, if you review the other open issues in the repo that this thread is in, you'll see that this...
duplicate of #417
duplicate of #417
Please add unit tests.
Adding my current thoughts, but please don't read this as "changes required", it's just an update because I've not got review feedback ready yet. Definitely wait for @CelticMinstrel to comment...
> It's already hard enough to figure out what is causing an OOS error, so we shouldn't knowingly be adding more ways to cause them without very compelling reasons. Good...
Still wondering whether `specials_alignment` could return a `unit_alignments::type` or `std::optional`, and therefore avoid duplicating code from `combat_modifier(effective_tod, alignment, is_fearless)` or `generic_combat_modifier`. My feeling is that it feels like too much...
> it's done. Thanks. It needs a minor fixup, it seems the old version of alignment_bonus crept back in during your rebase, but that's the direction that I wanted it...
I've been wondering if it's worth the complexity below. Definitely not going to do this for 1.16.1. ``` # po: This combines two other strings that use the "rescue timer^"...
> It looks like all that remains for this PR is the last to review comments about the WC settings dialog? That and some trivial trailing-whitespace cleanups that the WML...