Results 302 comments of Steve Cotton

> I think 16, 19a, 19b, 22 are good to me. I'm preparing a commit with those four now.

> Looks like the changes to schema.cfg are just whitespace, so should probably be removed from this PR. They're already in the master branch, so turning this into a squash...

Edit: at the time this comment was made, there was a flamewar here; all comments from one of the users involved have been removed since then. Gentlemen, could I redirect...

I'm trying to work out why `[remove_unit_overlay]` needs an id, and currently the only reason I can think of is that WML wants to remove the object later; doing this...

@soliton- did you see any reason why it should need an id? Is the issue just that the two methods seem inconsistent?

Because having an overlay suggests that a unit is special in some way, and removing an overlay suggests that whatever caused that has ended. For example, a dehydration mechanic where,...

Temporarily removing an overlay for a turn or for a scenario could be done by using `duration=`, doing it for a single event's animation could be just a `[store_unit]` and...

Even for the tools domain, this doesn't feel worth breaking the string freeze.

It would be possible to concatenate translatable and non-translatable strings, however in this case the existing string is multi-line: https://github.com/wesnoth/wesnoth/blob/37a45c32cef0a0b96f4872b7382015fa076335ed/po/wesnoth-tools/ar.po#L490-L507

> Temporary schema validation adjustment Swapping around stdout and stderr doesn't help, the problem is that `--validate` doesn't imply `--no-log-to-file` #7310. ``` error preprocessor: Macro/file 'campaigns/Son_Of_The_Black_Eye/units' is missing at campaigns/Son_Of_The_Black_Eye/_main.cfg:81...