Steve Bennett
Steve Bennett
>Ok I'm willing to be optimistic, though think we'll have to take the overloading approach to stand a chance. I think I have achieved this now in my latest commit....
Btw after doing a bit more close reading, I should correct some of my statements: - a `Polygon` with coordinates `[]` is not in violation of the spec, as far...
So...after all that (sorry!), I've reverted back to returning a `Polygon` with empty coordinates array when the Polygon is outside the clip region. I think I was confusing each ring...
> > A wrinkle I hadn't considered was that if you pass a non-specific geometry type in, you should just get a non-specific geometry out. > > Would you mind...
Hmm, I didn't think about JSdoc. I doubt it can handle anything as complex as the overloads, but it should have the other types added at least. I'm away for...
Ok, I have updated the doc. Also, since it seems that currently polygons are *not* split into MultiPolygons I have updated the doc to reflect that, and added test cases....
Btw, just checking - is there anything else I need to do? Or is it just a question of waiting until someone has time to review and merge? Happy to...
Thanks @jfirebaugh, I didn't realise that. It might be worth mentioning in [the docs](https://www.mapbox.com/mapbox-gl-js/api/#geojsonsource) that GeoJSON sources aren't validated.
It's up to you obviously, but IMHO, a customizable toolbar is overkill (and not really a user-friendly option), and I think my proposed solution serves the most common use cases...
Ah, that's interesting. I guess one could kind of use that system to achieve absolute priorities by using a scale like 1, 10, 100, 1000 etc instead of 1,2,3,4.