Steve Bennett comments

Results 224 comments of


                                            Steve Bennett

Expose `featureCount` property. Fixes #40.

Might be confused with file size, but up to you.

TypeError: createLogger is not a function

Yeah I think somewhere in the process of updating to use the new module syntax, the old syntax got broken.

Add syntax highlighting for all fenced code blocks in README

Thanks for much for the PR - unfortunately, it doesn't work, see #35

[Feature request] Add handler for source and layer loaded events

Ah, interesting suggestions. What does "load" mean for you in each of these contexts, and what are your use cases exactly?

[Feature request] Add handler for source and layer loaded events

Yeah, the inability to consistently detect these events is such a huge pain point :/ If you can come up with an implementation you're satisfied with, I'd be happy to...

[Feature request] Add handler for source and layer loaded events

Thanks for this - looks useful. I will have to look more closely. I'm a little bit iffy about the function signature (having to spell out `onLoadStart` and `onLoadEnd` ...)....

[Feature request] Add handler for source and layer loaded events

>Triggers on geojson when zooming and panning, like if load was batched internally. I may have misunderstood how geojson works, but I thought it was loaded at once. GeoJSON is...

[Feature request] Add handler for source and layer loaded events

Thanks, this is great.

make layer type optional in props?

Yeah, interesting idea. I think personally I probably wouldn't use it much, due to the ambiguities. And also that semantic differences start to get conflated - `line-offset` has a bit...

Mapbox GL JS v3 Support

Can you elaborate? What have you seen? The main thing I notice is that map.getStyle() returns a very different structure with no layers. I'm still trying to work out how...