Paul Berry

Results 149 comments of Paul Berry

Enable promotion for private final fields and fields on non-escaping private classes

@rubenferreira97 I'm back to actively working on this. I hope to be able to release it as part of Dart 3.1.

https://dart-lang.github.io/linter/lints/no_logic_in_create_state.html page lacks of advices

I'm going to take a stab at this.

Improve context schema rules for `await`

I like the principled nature of @leafpetersen's analysis in https://github.com/dart-lang/language/issues/3571#issuecomment-1899745967. When I was trying to write up the issue in the first place, I think I was trying to mentally...

Improve context schema rules for `await`

@lrhn: > But, if we want to be consistent, should we recursively process deeper nestings, like a context type of `FutureOr` also brought reduced to `T?`? Yeah, I suppose we...

BoxDecoration doesn't respect repeatX/repeatY when fitWidth/fitHeight is used.

I've done some debugging, and I believe I've narrowed down the culprit to a bug in the `applyBoxFit` function. I'll upload a fix for review shortly.

Require the static type of all expressions to be a subtype of their context; push coercions down to satisfy this.

@dart-lang/language-team As discussed in today's language team meeting. Let me know what you think!

Require the static type of all expressions to be a subtype of their context; push coercions down to satisfy this.

I'm starting work on this. I plan to do a prototype first, then see how much breakage it causes inside google3. Once I have that information we can re-assess whether...

How do we expect required context types to interact with `await`?

@leafpetersen said: > Is my interpretation of the intended semantics above correct? Yes, I think so. > Is this change expected/desired? If so, do we have any data on how...

How do we expect required context types to interact with `await`?

One other thought: In some other issues recently I've been talking about the idea of extending type schemas with a `coercibleTo` operator. If we did that, we could potentially address...

How do we expect required context types to interact with `await`?

I've done some additional prototyping along the lines suggested in this discussion, and I'm less certain about whether requiered context types are necessarily a good idea anymore. If they are...