Paul Berry

Results 149 comments of Paul Berry

Fixed by https://github.com/dart-lang/sdk/commit/c3ce683cca524069c6237a4e60c281ac519513a8.

@eernstg said: > @stereotype441, these changes would presumably be valid when the spec and implementation changes discussed in [dart-lang/language#3100](https://github.com/dart-lang/language/issues/3100) have been performed. What's the right ordering/scheduling of these changes and...

> I think the changes are significant enough that they should be language-versioned, which means that we should handle them the same way we handle other language versioned features. That...

I dug through the implementation a bit, and this is definitely a bug. When analyzing a switch statement, flow analysis potentially has to keep track of promotions to two different...

> > There is _no_ propagation of contexts through recursive inference, the context type used is recognized immediately at the ``→` *` grammar production, and stored where it belongs. (Can...

I believe the problem in the second example is that the analyzer's `FunctionExpressionInvocationResolver` doesn't properly resolve the type of the "function" (`createT()` in this case) from a type parameter type...

> [@stereotype441](https://github.com/stereotype441), can you help me with this, or ping someone else, please? Thanks! I'm quite familiar with how the resolver works, but not too familiar with what information the...

Thanks for the context, @FMorschel, that really helps! What's happening here is that the analysis server's completion engine is doing something a little bit dicey, which is that it's relying...

> No matter where I try to get this information from, it seems to be unable to tell me what type is expected. Any tips? > > **Edit**: The CL...

Aha, I see it! You're missing an import. This fixes the problem: ``` $ git diff diff --git a/pkg/analysis_server/test/services/completion/dart/location/record_literal_test.dart b/pkg/analysis_server/test/services/completion/dart/location/record_literal_test.dart index 2bf2e2ba5f9..c38b8154a62 100644 --- a/pkg/analysis_server/test/services/completion/dart/location/record_literal_test.dart +++ b/pkg/analysis_server/test/services/completion/dart/location/record_literal_test.dart @@ -451,9 +451,10...