Nicolas Sterchele

Results 11 comments of Nicolas Sterchele

@eikenb There is already an environment variable for setting the log level. Look at https://github.com/hashicorp/consul-template/blob/master/config/config.go#L526-L530 You can use `CONSUL_TEMPLATE_LOG` or `CT_LOG`...

I propose to remove `CT_LOG` and add `_LEVEL` as suffix for `CONSUL_TEMPLATE_LOG`

The re-request review button doesn't work... then I ask a re-request review by message @chenhengqi, please.

@chenhengqi, new version with fixes requested here 61b39bdda3c14868739fac0d759014ec7a119cb3

> You should remove delta = delta / 1000; from BPF program. Fixed @chenhengqi 👍🏼

@chenhengqi Do you know who is responsible to merge libbpf-tools PR?

Any news on this @davemarchevsky?

> @sterchelen Please rebase and push again. Done @chenhengqi

Indeed. And letting class subcommand as it is... `hssp class 1`. Sounds good to you?

To me we could have two exercises: > One way to compare strings using just the Zig language is to compare them as an array of `u8` bytes. You could...