Albert Steppi

Results 269 comments of Albert Steppi

@izaid, I think I've addressed everything. Thanks for the suggestions!

> Thanks @steppi! Looks good to me. Thanks @izaid!

Thanks @rlucas7. Good catch. I'll update the comments.

@rlucas7. It’s unrelated. It’s failing everywhere.

Thanks for the suggestions @fancidev. > A small comment about `series_eval` for @steppi : instead of accepting a `Generator`, have you considered accepting an `Iterator`? I come across this when...

@fancidev. Ah, I see what you mean. That does sound like a good idea. Thanks.

> I come across [this line](https://github.com/scipy/scipy/blob/09769690f65cfc078c860f960f084aa3689df5b4/scipy/special/special/hyp2f1.h#L200); wonder if it’s a typo? The comment wants u > v, but that lines makes u < v. Good catch. Yes, the comment has...

> Actually I mean the code appears to have a typo. Because u, v, w, x are passed to four_gamma_lanczos; but in that function it is expected that u >...

Thanks @lagru. > * For our main documentation, we are indeed using the pydata-sphinx theme. The theme seems to have its own [internationalization support](https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/i18n.html) but I'm not sure how mature...