Albert Steppi
Albert Steppi
@mdhaber, I'll merge this after the conflicts are resolved.
As expected, I did in fact mess up something in `scipy/.github/workflows/lint.yml`. I'm signing off for the night, but will look into it tomorrow.
Thanks for the reviews and helpful suggestions @j-bowhay, @lucascolley, and @mdhaber, and the kind feedback @rgommers. I've committed the code suggestions that were made through GitHub, which I think were...
OK, I think that addresses all of the review comments that have come in so far, but I'll go through them all again to make sure I didn't miss anything....
The `check-xp-untested` job still wasn't working, so I moved it to `circleci` where it should be easier to get working by copying what is done for `refguide-check`.
Huh, `check_xp_untested` is failing with a bunch of false positives in CI even though it works for me locally.
The problem with `check_xp_untested` was that the CI job wasn't installing all of the test requirements. Tests missing these optional requirements weren't getting collected, so it looked like there were...
CI unearthed some tests for `marray` that still need the `uses_xp_capabilities` mark. These tests were getting skipped locally because I didn't have `marray` installed in the `venv` I was using....
Ha, despite writing this and seemingly having come to my senses: > I realized, that really, it makes sense that the input dtypes and expected output dtypes in tests should...
> I think we need the build deps too... > > ``` > scipy on 🎋 xp-testing-docs [?] is 📦 v1.18.0.dev0 via 🐍 via 🧚 v0.60.0 > ❯ pixi run...