Albert Steppi

> I know you don't like these comments but this is precisely how things go with C++, slowly things creep into the codebase because some very obvious thing is missing...

> Awesome to see this happening. Side note: a root finder that exploits monotonicity would be useful also in `optimize.` It is probably outside of the scope of your grant...

Thanks for the comments on the bracket finder @fancidev! On another branch, which unfortunately I haven’t pushed, I have a more complicated bracket finder which facilitated finding either the least...

@fancidev, sorry, what I wrote about the plateau handling above is nonsense. I think there was a genuine pathological case that was fixed by not moving the trailing endpoint, but...

Marking as draft because there are regressions in runtime performance that I need to work on.

I've updated this to use [Chandrupatla's algorithm](https://www.sciencedirect.com/science/article/abs/pii/S0965997896000518) instead of Bus and Dekker's algorithm R. It is slightly more accurate, and much faster on average. Due to it's simplicity it absolutely...

Thanks @fancidev for the thorough review. I think we have this in good shape now. Let me know if you have any more suggestions.

Thanks for the review @izaid! Great suggestions. I was able to banish the function pointers by putting the `if/else` inside of `func` instead of outside of it. I've verified locally...

Thanks for the review @mdhaber! > * When `a` and `p` are valid but `x = 0`, I'm seeing a numerical result without a warning, but `gdtr` produces a NaN...

> * Could you give an example of what happens when a root can't be found (if such an example exists)? Some background: the assumption is that the function is...