Stephen Fraser

Results 55 comments of Stephen Fraser

I think this is a good addition for fully-static search, but I think there are a few more things that would make it more viable for larger sets of search...

Heres an example of a vanilla NWB install (0.19.1) with storybook installed: https://github.com/how-to-react/nwb-storybook The commit that gets it working is here: https://github.com/how-to-react/nwb-storybook/commit/2d86666bca48a5688e25ab98f220a125716ce832 If you're just interested in getting the webpack...

Ah I see, so the webpack config in that example uses something like `require.resolve(...)` to get the path to the file. That would be ideal. I did run into a...

@adamchenwei It's been a few years since I've looked at this problem. Would it be useful if I created an updated NWB v0.25 + Storybook 5 example?

@adamchenwei Have tested with a vanilla installtion: - Run `npx nwb new react-app nwb-storybook-5` - cd into folder - Run `npx sb init` Storybook works fine in this case, with...

Change looks good. This will be a breaking change for the UV as it sometimes casts the output of `getSequences()` like: ```typescript const sequences: Array = manifest.getSequences(); ``` I know...

`Canvas.getContent(page: number | string)` could return either the index or by id. Did that recipe come from the cookbook? Looks like both pages have the same Identifier, which could cause...

Given that manifesto is an abstraction, I'd be inclined to agree with both implementations. Having a `Manifest.getSequences()` that returns a range or set of ranges, falling back to perhaps a...

That sounds easy enough, so maybe all we need is a `getSequences()` to return the appropriate ranges on a manifest?

And then with your changes @MImranAsghar in #79 we should have enough to gather the running order of the canvases.