Stephen Fraser

Results 43 comments of Stephen Fraser

While on the point of refactoring the Repository class, maybe its worth adding an interface for the repository. For example, storing on an S3 bucket may require extra some extra...

They are when using the component itself. So using the example above: ``` javascript var SomeOtherComponent = { view(ctrl, props, children) { return } } ``` Now props.someproperty can be...

I think that's correct @irv. However trying in an independent [tile renderer](https://codesandbox.io/s/canvas-panel-web-component-demo-image-service-forked-yt788e?file=/index.html) it is possible for a viewer to work around it. Maybe something OSD could look to fix

Would a move to relative spacing (like `em`s) fix the issue?

@demiankatz I was having some problems with the files being gitignored! Looks like the storybook config isn't there. Let me change that now 👍

@plusin it looks like the UV is making requests to the image service: ``` http://fadu.cyberciudad.com/service.php/IIIF/representation:14/full/90,67/0/default.jpg?t=1624967628802 ``` But they are not being generated. Could it be possible something is not working...

I think there are 2 factors. The height is set here: https://github.com/UniversalViewer/universalviewer/blob/2a08b8aa87dce7dd5d4d6c65c63df495bebe9775/src/modules/uv-shared-module/ThumbsView.ts#L45-L57 Calculated from the median height of the images. https://github.com/UniversalViewer/universalviewer/blob/2a08b8aa87dce7dd5d4d6c65c63df495bebe9775/src/modules/uv-shared-module/ThumbsView.ts#L137-L142 The property used appears to be `thumbs.height` which _may_...

@dhrobinson How is this looking: https://deploy-preview-858--uv-v4.netlify.app/#?manifest=https://digitalcollections-api.arts.ac.uk/iiif/objects/koha:1482749&c=&m=&cv=&xywh=

@ksclarke I'm sorry I was not able to replicate that sizing on Chromium/macos - but manually changing the line-height of the title seemed to push the video down slightly. I...