Stephen Haberman
Stephen Haberman
Hi @simonenkoav , thanks for filing the issue! Honestly it sounds like you've done a great job of dissecting what is going wrong--if you could turn those insights into a...
Hi @srliao ; it looks like this code: https://github.com/stephenh/ts-proto/blob/38b114c2169b5aa6d1b92d446fb40ee39099c196/src/generate-struct-wrappers.ts#L58 Is not respecting the `useJsonName` flag--if you could submit a PR that fixes that, and ideally add a `Struct` usage to...
Hi @atassis ! Definitely agreed "there is a lot going on" in the readme. :-) Any refactoring / clean-up you'd like to do would be amazing; thank you!
@atassis this looks great! Are you thinking we'd just swap your `supported-options-new` for the READMEs current options section? Happy to do that, when you're ready
@atassis cool, that sounds fine to me as well
Hi @marcaddeo ! Apologies for the late reply, I have to batch when I triage ts-proto issues... I'm not sure why we haven't exported `Rpc`, but that makes sense; if...
Wow, that's weird; I really can't figure out who is to blame. Turning on `NODE_DEBUG=module` gets a little more output like: ``` MODULE 9: Module._load REQUEST worker_threads parent: /ts-proto/node_modules/esbuild/lib/main.js MODULE...
Hi @absidue ; I agree this would be a good improvement. You mention making it conditional based on `env=browser`; not against that, but honestly I wouldn't mind just trying it,...
> we can keep a tally of what we actually need to output into the helpers file. Currently we use the Conditional Output feature of `ts-poet` to do track "what...
Seems like there is a good Knex-driven-by-postgres.js adapter here: https://github.com/knex/knex/issues/3642#issuecomment-588054490