Results 593 comments of Stephen Haberman

Hi @sefaphlvn , apologies for the late reply! The approach that ts-proto's sibling/child project, ts-poet, uses for code generation is to make "a giant unformatted mess of code" and then...

@sefaphlvn that looks great! Let me know when/if you open a PR; unless you already did and I just missed it. Thanks!

Hi @alextsg ! I mean, at this point we're shooting for the moon on the number of opts that ts-proto supports, so why not! :rofl: Some sort of `affixEnums=true/false` maybe?

@alextsg ah I see, `typePrefix` is both, but `messagePrefix` / `enumPrefix` are the individual ones...yeah, that sgtm!

Hi @jas-chen ! This looks amazing! Just scanning the PR, everything looks great, but I won't have time to review more thoroughly until this weekend, if that's okay...I'll take a...

Hi @jas-chen ! I think we can do this like this: https://github.com/stephenh/ts-proto/pull/1078 Unfortunately it looks like we might have a bug in our extensions support, because I'm getting this error:...

@jas-chen hello! Sorry, I've just been really busy with work lately; I definitely want to review & accept this PR--I should be able to review/accept it this weekend when I...

Hey @williamsk91 , @angelorc , sorry, this is a larger PR in an area that I'm not very familiar (I don't personally use `google.api.http`), so reviewing this PR has been...

Hi @paskozdilar ! Just sanity checking, but have you seen our existing oneof handling, i.e.: https://github.com/stephenh/ts-proto?tab=readme-ov-file#oneof-handling And specifically the `oneof=unions-value` option? It outputs code like: ``` interface YourMessage { eitherField?:...

Makes sense! We should be able to detect "over 63 chars" and rewrite `aaa_bbb_to_ccc_ddd` to `ab_to_cd` or what not. Or maybe keep the 1st part if possible, so `aaa_bbb_to_cd` just...