Stephen Haberman

Fwiw today we tried bumping to node 16.2.0 to get this perf fix, and are seeing errors in our app that does this ~admittedly somewhat esoteric pattern with `async_hooks`: ```typescript...

Okay @rochdev and @Qard , we believe we have a reproduction in this PR: https://github.com/stephenh/joist-ts/pull/122/commits Notice that it passes on 16.1.0: https://app.circleci.com/pipelines/github/stephenh/joist-ts/547/workflows/247c2b9d-8d01-463f-bfce-f1163a36f221/jobs/581 But fails on 16.2.0: https://app.circleci.com/pipelines/github/stephenh/joist-ts/547/workflows/247c2b9d-8d01-463f-bfce-f1163a36f221/jobs/579 A few notes:...

@rochdev that's a fair ask! I think we were so pleased with ourselves to having isolated the repro that we didn't push farther to make it as simple as possible....

I worry about the inevitable namespace collisions from messages with the same name being in different proto files, but otherwise yeah this seems like a good idea.

@alexisvisco can you clarify that with a concrete example?

@damian-bisignano can you update your tsconfig to have a lower `target`: https://www.typescriptlang.org/tsconfig#target I.e. `tsc` can understand `1_000` and handle de-sugaring that to just `1000` for older JS runtimes.

Hey guys, coming across this much later, so sorry about being quiet on it... I'm not personally a NestJS user, but I believe the issue, as I just mentioned in...

@danduh AFAIU someone figured out that NestJS's encode/decode can be intercepted using the protobufjs `wrappers`: https://github.com/stephenh/ts-proto/issues/69#issuecomment-1096981570 But it's not been integrated into ts-proto yet. If you want to submit a...

Hi @danduh , yeah, the idea with this ticket would be to have ts-proto output this: ``` wrappers['.gaas.GeoUnions'] = { fromObject: ()=>{ // not implemented }, toObject:(message, options) => {...

Huh, thanks for the report; I kinda thought this code should already handle that: https://github.com/stephenh/ts-proto/blob/84060e204d0e42688b8da85d434fe3d24788813b/src/generate-grpc-web.ts#L54 ``` function generateRpcMethod(ctx: Context, serviceDesc: ServiceDescriptorProto, methodDesc: MethodDescriptorProto) { const { options, utils } =...