Stephen Haberman
Stephen Haberman
Hi @dasco144 ; ah, that makes sense. I think nearly all users end up invoking ts-proto via a protoc command line call, so historically I've not really worried about this....
Hi @thomasboyt ; what you describes makes sense, and yeah "just run ts-proto twice" sounds like a great short-term fix! But, yeah, having propertly-typed `toJSON(): PersonJSON` types would be pretty...
Ah shoot; thanks for the report @jokerttu , and yeah it's probably related to the deep-or-shallow wrap/unwrap discussion from this thread: https://github.com/stephenh/ts-proto/pull/762#discussion_r1091292423 cc @ZimGil if you'd like to take a...
Closing as stale
Hi @pbhuynh , just taking a look--sorry @alexeyten , you had some great work here, and I must not have had time to review it/think about it when you first...
:tada: This issue has been resolved in version 1.135.3 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/ts-proto/v/1.135.3) - [GitHub release](https://github.com/stephenh/ts-proto/releases/tag/v1.135.3) - `v1.135.3` Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:
A lot of work for proto2 optional fields was just done in #1007 that hopefully addresses this, so going to close this out.
Ah yeah, @maxgr0 it's been awhile but scanning the PR I think I was hoping to see the feature trimmed down a little bit, and be just `removeEnumPrefix=true` that only...
@superclaw ah sure, a new PR would be great!
This landed in #779 , thanks @Toofifty / @superclaw !