ts-proto icon indicating copy to clipboard operation
ts-proto copied to clipboard

Published 20 hours ago • verified publisher icon stephenh

refactor: support proto2 optional

Open ssilve1989 opened this issue 5 years ago • 5 comments

References #139

ssilve1989 avatar Oct 26 '20 19:10 ssilve1989

Any chance we can get this merged? :)

elderapo avatar Feb 02 '22 18:02 elderapo

@elderapo unfortunately the PR is pretty out of date, and had several unanswered questions from the original review, plus an ask for a test, so as-is, chances of being merged are low.

If you'd like to pick it up, rebase on main, add the test, that would be great!

stephenh avatar Feb 03 '22 00:02 stephenh

@ssilve1989 any change to merge? :)

deser avatar Mar 17 '22 02:03 deser

@philikon any change to merge? :)

deser avatar Mar 30 '22 19:03 deser

Please merge this 🙏

garrappachc avatar May 09 '22 22:05 garrappachc

A lot of work for proto2 optional fields was just done in #1007 that hopefully addresses this, so going to close this out.

stephenh avatar Mar 13 '24 14:03 stephenh