Stephen Gold
Stephen Gold
Also, the dialog changes have major impact so I think they should be discussed at the Hub/Forum before this is integrated.
I notice that the "Show Setting" checkbox in the test chooser no longer works. Please fix that. > I'll remove the native patch from this PRs and commit it directly,...
> Should be fixed now Tested and confirmed. > I opened a thread here Looks good. Thank you.
I got distracted today and didn't have time to study this PR in depth. Hopefully tomorrow...
I don't understand why the `SKIP_SETTINGS` variables were removed from `TestIssue1120` and `TestGImpactShape`. How do those changes relate to this PR?
> Isn't SKIP SETTING used to skip the setting dialog there? Yes. And?
Okay, the removals make sense then. I'm trying to run apps in jme3-examples on Linux (this branch of JME) and every test so far has failed. Here's a typical crash...
> Why 3.1? I noticed that, too. I suppose that might be because Riccardo's fork lacks any recent build tags: ```console sgold:~/Git/riccardo/jmonkeyengine$ git tag 3.1-github-tag-test 3.1-snapshot-test 3.1-snapshot-test-2 3.1-snapshot-test-3 3.1-snapshot-test-4 test123...
I'm interested in writing a new version of Settings Dialog that doesn't use AWT/Swing. @riccardobl: Instead of removing/disabling the dialogs, would you consider revising this PR so it's not a...
I think it would.