Stephen Berry

Results 391 comments of Stephen Berry

@huangminghuang, yes I saw that race condition recently and need to tackle it. It's not from your code.

@huangminghuang, I just made a change to your pull request that allocates a `static thread_local` instance of the default class. Your code would allocate and then destroy an instance every...

One other aspect of this pull request that we might want to change is the behavior of the `skip_null_members` options when the `skip_default_flag` is set. Currently in Glaze the `skip_null_members`...

I agree, any general option for skipping defaults would need an opt-out option, like you've noted with glz::custom.

Currently Glaze expects `std::array` to be an array of characters: `["a", "b", "c"]` We could make `std::array` behave as a string type, but I'm not sure this is a good...

I'll also note that you can still use c-style arrays, you just need to write a `glz::meta` for your struct.

After thinking about it some more, I do like the idea of `std::array` behaving as a string. I've added support here: #1247. However, I'd still like to hear your thoughts.

@pwqbot, I made a `stack_string` implementation using a custom allocator for `std::basic_string`. However, I'm trying to figure out error handling. I would like to use std::errc `not_enough_memory` to handle out...

@pwqbot, neat! `std::basic_fixed_string` looks like the appropriate solution for the future, because it will allow us to still use `std::array` for JSON arrays of characters and `std::basic_fixed_string` for actual stack...

Sweet, I'll use that implementation for reference