Stephen Berry comments

Results 391 comments of


                                            Stephen Berry

`glz::json_t`double serialization, how to customize format?

Thanks! I was trying to figure out the failure point. Technically Glaze is conformant to the JSON specification by writing out a floating point number as `1`, and other JSON...

`glz::json_t`double serialization, how to customize format?

I want to use std::format underneath to enable precise formatting for special cases. This requires GCC 12 to be deprecated. GCC 15 is now out, so I'm thinking of making...

std::span<char const> is not serializable

Thanks for looking into this. It would be great to support `std::span`. > //this is invalid -> return *value.data() ? sv{value.data()} : ""; I think you might be confused with...

std::span<char const> is not serializable

> I will mention again here is active buffer overflow Good point, although this is a corner case and it's impossible to check if a `const char*` actually points to...

std::span<char const> is not serializable

Oh yes, that is bad default behavior.

std::span<char const> is not serializable

> And to explain why I am looking into that, I have a code which has string tables containing large string data as single table + table of offsets... Thanks...

std::span<char const> is not serializable

I agree, that was my final comment. If you want to go ahead and make this change I'd welcome a pull request.

std::span<char const> is not serializable

Thanks, take as much time as you need.

std::span<char const> is not serializable

No problem, I'll let you know when I start working on this, otherwise do the same and I'll wait for a pull request.

implement skip writing out default

This is awesome! Thanks for tackling this desired feature of skipping default values. I look forward to merging this, but I want to walk through the code changes carefully first....