Stein Krogstad

I think it's preferable to merge anything in the pipeline before https://github.com/OPM/opm-simulators/pull/5157. I'm also hoping to get in a few improvements prior to https://github.com/OPM/opm-simulators/pull/5157

I have the same impression, I haven't seen anything worrying. I am a bit surprised that it affects this many cases though, but there's probably some effect I haven't thought...

So probably no worries here, but I guess we should make sure we don't miss anything. @GitPaean and @totto82 , could we just devide the 60 failed tests between us...

Looks like there are some issues that needs fixing here. Seems to be missing a `calculateExplicitQuantities` in the potential calculations for STW. Hence, with the PR, there is zero p-drop...

I've started to run the tests for seperate parts of the PR in attempt to get a better overview. I don't know whether the `--local-well-solve-control-switching`-option has ever been run on...

I'm working on this and have gone through all failures that `--local-well-solve-control-switching=true` are contributing to. This was a larger number (175) than anticipated and mainly due to differences in potential...

@GitPaean @totto82 thanks! From what I can see, differences are small compared to e.g., changing the linear solver ;). At some point we discussed having a seperate _well_state_ for the...

> Turning of the local switch control with --local-well-solve-control-switching=false can avoid to get BHP lower than the bhp limit. Maybe it is something interesting to investigate. @steink There are quite...

> This PR with --shut-unsolvable-wells=false restore Norne results Looking into this. Currently a well that has reached it's maximum switching limit is not only prevented from switching control, but also...

@totto82 could you make the following small update: https://github.com/OPM/opm-simulators/commit/aec51705bb01951f87351562213d73f93018f093 ? This will prevent forcing a non-operable well to be open in cases the control mode is forced (prevents well convergence...