Stein Krogstad comments

Results 45 comments of


                                            Stein Krogstad

When checking for zero target rates, also check wells under group control where required

I've restructered everything here, and renamed the original functions `wellUnderZeroRateTarget` and `stoppedOrZeroRateTarget` to `wellUnderZeroRateTargetIndividual` and `stoppedOrZeroRateTargetIndividual`, respectively. The functions `wellUnderZeroRateTarget` and `stoppedOrZeroRateTarget` now also include checking for zero targets from...

When checking for zero target rates, also check wells under group control where required

> At the same time, can you check the Jenkins failures to see whether the failures are relevant? Especially the ones with related to `MOD4_GRP`. Yes, will look into what's...

When checking for zero target rates, also check wells under group control where required

Have looked at the four failing tests here. _NETWORK-01-REROUTE__ and _NETWORK-01-REROUTE_STD_ match very closely. For _MOD4_GRP_GEFAC_ there is slightly different time-stepping with the PR, but otherwise close match. Looked a...

When checking for zero target rates, also check wells under group control where required

jenkins build this please

When checking for zero target rates, also check wells under group control where required

I've gone through the failures and think they look OK. For most of them it's just a result of different time-stepping/different number of time-steps which in many cases leads to...

When checking for zero target rates, also check wells under group control where required

> The thing is a little worrying is that, when we check the group target for a well, the group target might not be ready. Yes, but don't you think...

When checking for zero target rates, also check wells under group control where required

>It took some thinking to understand your point. Basically, you meant that without the checking, we will solve it with zero rate target in the master branch. I think your...

When checking for zero target rates, also check wells under group control where required

> @steink , can you update the PR to fix the merging conflicts, then we can check how to adjust and update the reference so that we can get the...

When checking for zero target rates, also check wells under group control where required

> please grab rebased branch from https://github.com/akva2/opm-simulators/tree/check_zero_target_from_group. note I squashed the previously botched rebasing, makes no sense to keep that history. Thanks @akva2 !

When checking for zero target rates, also check wells under group control where required

Thanks for the help on this. I've looked through the code and looked breifly through the failures. Failures are consistent with the ones reported before merging/rebasing (https://github.com/OPM/opm-simulators/pull/5232#issuecomment-2072326577). Also, I checked...